enable arm64 wheel tests, remove pytest.ini, add a coverage floor#438
Merged
rapids-bot[bot] merged 9 commits intorapidsai:mainfrom Apr 9, 2026
Merged
Conversation
jameslamb
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
jameslamb
force-pushed
the
misc/testing-improvements
branch
from
91be23c to
8c3ee14
Compare
1 task
jameslamb
commented
Mar 31, 2026
jameslamb
commented
Mar 31, 2026
| ./ci/run_pylibwholegraph_pytests.sh \ | ||
| --cov-config=../../.coveragerc \ | ||
| --cov=pylibwholegraph \ | ||
| --cov-fail-under=15 |
Member
Author
There was a problem hiding this comment.
I'm proposing this because of all the test-skipping stuff added in #425 and #434 ... all that test-skipping logic makes me nervous.
Hoping that having a coverage minimum enforced right here, in a place where we expect torch to be installed, will help prevent bugs of the form "oops all the tests are being skipped" when the fixtures, import_optional(), etc. are refactored in the future.
…aph-gnn into misc/testing-improvements
Member
Author
|
/ok to test |
jameslamb
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
bdice
approved these changes
Apr 9, 2026
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposes some small testing improvements:
Contributes to rapidsai/build-planning#261
pytest.iniand moves its settings topyproject.tomlNotes for Reviewers
How I tested this
Enabled the nightly matrices for wheel-testing, to ensure this will cover all PR and nightly CI combinations.
Saw everything pass (after some fiddling to account for patchy aarch64 support with older
tritonpackages): https://github.com/rapidsai/cugraph-gnn/actions/runs/23859449526/job/69564135465?pr=438